Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #36822 - Removes an accidentally commented line in TableHooks #9899

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

parthaa
Copy link
Contributor

@parthaa parthaa commented Nov 8, 2023

The useUrlParams method table hooks had a line incorrectly commented. This cause ChangeContentSource page to not work because the search parameter in the URL was getting ignored. This commit fixes that by uncommenting and adding the friendlySearchParam method.

Copy link
Contributor

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this unbreaks change content source. 👍

@jeremylenz jeremylenz merged commit 108aed5 into theforeman:develop Nov 8, 2023
11 checks passed
@parthaa parthaa deleted the table-hooks-fix branch November 8, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants