-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36898 - Add rack-mini-profiler for profiling #9897
base: develop
Are you sure you want to change the base?
Conversation
b5a17d9
to
b50aa3a
Compare
b520fe8
to
cab4485
Compare
cab4485
to
1715913
Compare
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
1715913
to
2d39e52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, but I'd like to wait until after branching so we have a bit more time to evaluate it in nightly.
Agreed, would it make sense to move the |
Possibly, but it's only enabled in development mode: foreman/config/environments/development.rb Lines 47 to 56 in 8bd953d
So if you move it to profiling (which you also intend to be usable in production mode) the I'd expect it to setup to also happen in the production environment. |
I tried it, but the |
That surprises me because https://github.com/flyerhzm/bullet#configuration states:
in production |
Branching was already done some weeks ago. Can we continue with this? |
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]> from theforeman#9897
Packaging PR: theforeman/foreman-packaging#9953