Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the values from matrix.json in JS tests #9880

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Oct 27, 2023

No description provided.

.github/workflows/js_tests.yml Outdated Show resolved Hide resolved
@evgeni
Copy link
Member Author

evgeni commented Oct 31, 2023

matrix:
node-version:
- 14
matrix: ${{ fromJson(needs.setup_matrix.outputs.matrix) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can somehow be smart and only test on the first Ruby version. Running the JS tests with all Ruby versions probably doesn't make sense.

Suggested change
matrix: ${{ fromJson(needs.setup_matrix.outputs.matrix) }}
matrix:
ruby:
- ${{ fromJson(needs.setup_matrix.outputs.matrix).ruby[0] }}
node: ${{ fromJson(needs.setup_matrix.outputs.matrix).node }}

But perhaps with webpack 5 the webpack config no longer executes Ruby to determine plugins (not sure, couldn't see it immediately) and it no longer needs Ruby.

Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
@evgeni evgeni force-pushed the load-matrix-in-js-tests branch from 3de15eb to e64dcf1 Compare October 31, 2023 16:39
@evgeni evgeni merged commit 8d1f863 into theforeman:develop Oct 31, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants