Fixes #36867 - Add host delete & create to new host overview #9878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
force-pushed
the
36867-add-delete-and-create
branch
from
3cc493c to
a879797
Compare
pr-processor
bot
added
Waiting on contributor
and removed
Waiting on contributor
labels
jeremylenz
force-pushed
the
36867-add-delete-and-create
branch
from
c19b11c to
d6a8e46
Compare
jeremylenz
force-pushed
the
36867-add-delete-and-create
branch
from
92a964c to
1898c26
Compare
|
Companion Katello PR: Katello/katello#10782 |
ekohl
changed the title
jeremylenz
force-pushed
the
36867-add-delete-and-create
branch
2 times, most recently
from
7062fdf to
e204351
Compare
jeremylenz
force-pushed
the
36867-add-delete-and-create
branch
2 times, most recently
from
bfbe768 to
ba67f69
Compare
parthaa
approved these changes
Nov 2, 2023
| const dispatch = useDispatch(); | ||
| const { destroyVmOnHostDelete } = useForemanSettings(); | ||
| const deleteHostHandler = ({ hostName, computeId }) => | ||
| dispatch(deleteHost(hostName, computeId, destroyVmOnHostDelete)); |
There was a problem hiding this comment.
This per row delete operation seems to return me to /hosts/ while bulk delete returns me to /new/hosts after deleting. Do you think this should be fixed in #9879
There was a problem hiding this comment.
Will look into it
There was a problem hiding this comment.
So I reused the single delete action from host details, which actually appears to have the same (wrong) behavior. It's here:
I think #9879 is indeed the best place to fix it. In addition to the Ruby changes there, should do an audit in JS files of wherever we have foremanUrl('/hosts') (I only found 4). In those places we can useForemanSettings() to get the setting and set the url accordingly.
jeremylenz
force-pushed
the
36867-add-delete-and-create
branch
2 times, most recently
from
a18c0ad to
c77cdce
Compare
|
@parthaa updated: Moved endpoint to new controller & fixed rubocop. 👍 |
jeremylenz
force-pushed
the
36867-add-delete-and-create
branch
from
c77cdce to
2999007
Compare
jeremylenz
force-pushed
the
36867-add-delete-and-create
branch
from
7f4544e to
8537e5a
Compare
Add bulk modal with bulk params
add register/create buttons; fix links
address UX comments
Remove icon from delete action in the toolbar’s kebab
In the delete modal as a primary button use just “Delete”
(not delete host)
To the top part:
Add a kebab with legacy UI button
Ensure the loading screen doesn't say 'No Results'
support foreman_remote_execution slot
Refs #36867 - move action to new controller
move bulk hosts extension test to Foreman
jeremylenz
force-pushed
the
36867-add-delete-and-create
branch
from
8537e5a to
90fce22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following features to the new All Hosts page:
If you're using Katello, requires Katello/katello#10782