Fixes #36860 - Remove workaround for fixing layout rendering #9874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
Legacy JS
MariaAga
force-pushed
the
remove-showContent
branch
from
e5fccf2 to
c64e099
Compare
ekohl
reviewed
Oct 25, 2023
| @@ -36,14 +33,3 @@ export const hideLoading = () => { | |||
| export const changeActive = () => { | |||
| deprecate('changeActive', '', '3.8'); | |||
There was a problem hiding this comment.
This reminds me: we need to drop deprecated code. Looks like this function was actually a noop and can also be dropped. Probably doesn't belong in this PR though.
ekohl
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigation now loads before the content so the workaround is not needed.
The workaround causes issues in the Webpack 5 migration due to different loading order.
undoing most of: #6502