Fixes #36839 - Optimize apipie-dsl translate method #9866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
36839-optimize-apipie-dsl-translate
branch
from
164f47d to
ec40f41
Compare
|
[test katello] |
ekohl
force-pushed
the
36839-optimize-apipie-dsl-translate
branch
from
ec40f41 to
30116da
Compare
|
I didn't test it either, but how about this? |
ofedoren
previously approved these changes
Oct 19, 2023
ofedoren
reviewed
Oct 19, 2023
config/initializers/apipie.rb
Outdated
| FastGettext.set_locale(old_loc) | ||
| trans | ||
| end | ||
| config.translate = ->(stc, loc) { str ? FastGettext.with_locale(loc) { _(str) } : nil } |
There was a problem hiding this comment.
Suggested change
| config.translate = ->(stc, loc) { str ? FastGettext.with_locale(loc) { _(str) } : nil } | |
| config.translate = ->(str, loc) { str ? FastGettext.with_locale(loc) { _(str) } : nil } |
There was a problem hiding this comment.
Argh, I had that fixed on my laptop, then rebased on my desktop where I made the mistake in the first place ...
ekohl
force-pushed
the
36839-optimize-apipie-dsl-translate
branch
from
30116da to
422ab27
Compare
|
I don't think Katello failures are related, but just in case... [test katello] |
ofedoren
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.