Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36821 - Fix table pagination to be used separately #9859

Merged

Conversation

ofedoren
Copy link
Member

@ofedoren ofedoren commented Oct 10, 2023

New Table component is meant to be used within TableIndexPage template, but the table itself could be re-used separately from that template.

Pagination of that component expects parameters to be taken from URL, but in case the table is embedded in e.g. modal, the URL is not available as such. This patch makes Table component to be able to ignore URL dependency.

This mostly needed (and tested) for theforeman/foreman_openscap#546.

@github-actions github-actions bot added the UI label Oct 10, 2023
@ofedoren ofedoren requested a review from MariaAga October 10, 2023 21:20
@MariaAga MariaAga self-assigned this Oct 11, 2023
@MariaAga
Copy link
Member

LGTM, thanks!

@MariaAga MariaAga merged commit d8200ee into theforeman:develop Oct 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants