Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36796 - Make host_facts_updated event visible #9851

Conversation

ofedoren
Copy link
Member

@ofedoren ofedoren commented Oct 5, 2023

During #9780, a new event host_facts_updated was added. We do fire it on facts upload, but we don't show it to the users to be able to subscribe to it. This PR fixes that.

Needs foreman_webhooks to test this out.

@adamruzicka, could you please take a look?

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well. We should probably also pick this into 3.8

@adamruzicka adamruzicka merged commit 001a7ff into theforeman:develop Oct 5, 2023
6 checks passed
@adamruzicka
Copy link
Contributor

Thank you @ofedoren !

@adamruzicka adamruzicka added the Needs cherrypick This should be cherrypicked to the stable branches or branches label Oct 5, 2023
@ofedoren
Copy link
Member Author

ofedoren commented Oct 5, 2023

3.8 CP: #9852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs cherrypick This should be cherrypicked to the stable branches or branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants