use runuser instead of su to run rake as the foreman user #9839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
reviewed
Sep 21, 2023
Yes |
foreman-rake is designed to be run as root (and switch to foreman) or by
foreman directly. any other user can't use it as it is installed in sbin
and the foreman user has no password set, making switching users as non
root impossible, but su will still try it:
[nobody@foreman /]$ su foreman -s /bin/bash -c id
Password:
[nobody@foreman /]$ foreman-rake console
Password:
runuser is designed to be used in scripts and refuses to work as non
root:
[nobody@foreman /]$ runuser foreman -s /bin/bash -c id
runuser: may not be used by non-root users
[nobody@foreman /]$ foreman-rake console
runuser: may not be used by non-root users
adamruzicka
approved these changes
Sep 21, 2023
|
[test unit] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foreman-rake is designed to be run as root (and switch to foreman) or by foreman directly. any other user can't use it as it is installed in sbin and the foreman user has no password set, making switching users as non root impossible, but su will still try it:
runuser is designed to be used in scripts and refuses to work as non root: