-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36744 - VM tab (legacy UI) shows error in case host is not associated to VM #9832
Conversation
Issues: #36744 |
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
ok to test |
If the host will associated, the uuid is set: https://github.com/theforeman/foreman/blob/develop/app/models/host/managed.rb#L584 |
Thoughs about this @MariaAga ? |
Are the test failures related? |
@MariaAga I do not think so. In fact I ran them in my forklift and it passed 🤔
Maybe rerun the tests? |
All green now, thanks everyone! |
And thanks @MariaAga for merging :) |
Steps to reproduce:
Actual Result:
An error is shown
Expected result:
Upon registration, the host is not associated to a VM. In case the host is not associated to a VM, the VM tab should not be visible at all.