Fixes #36734 - Hide double title on Register Host page #9830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36734 |
MariaAga
requested changes
Sep 15, 2023
| }) => { | ||
| const title = ( | ||
| <TextContent> | ||
| <Text ouiaId="title" component="h1"> |
There was a problem hiding this comment.
Can you keep it breadcrumb_title?
theforeman-bot
added
Waiting on contributor
Needs re-review
and removed
Not yet reviewed
Waiting on contributor
labels
|
@kmalyjur test failures look related |
|
@MariaAga I added an additional |
|
can you please move the conditions to not show the page sections? so we wont end up with extra empty page sections that add space before the title. |
MariaAga
approved these changes
Sep 19, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed PageLayout so that breadcrumb, title, search bar and toolbar buttons work together even if some of the elements are missing.