Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35061 - Remove syncing of hostname on save_interface_modal #9591

Closed
wants to merge 1 commit into from

Conversation

Pigueiras
Copy link

No description provided.

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

2 similar comments
@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@theforeman-bot
Copy link
Member

Issues: #35061

@theforeman-bot theforeman-bot added Not yet reviewed Legacy JS PRs making changes in the legacy Javascript stack labels Jan 20, 2023
@Pigueiras
Copy link
Author

Probably this is not the correct fix because I guess that function save_interface_modal has some reason to exist for other use cases, but without it we don't have the issue. I'll try to explain again the bug that I added in Redmine so maybe someone can help to debug the issue:

If I have a node like:

image

And if I try to edit the environment or the hostgroup and press Enter (if I click with the mouse instead of pressing enter it works)

image

It removes the domain and puts the short name as name like:

image

And now if I don't put manually the full fqdn it causes the bad redirection error that I'm describing in the redmine issue (because the node is saved in the db with the fqdn, not the short name).

I'm also using this setting (not sure if it has anything to do with the issue we're having).

image

@MariaAga
Copy link
Member

Hi, could you check if this pr: #9564 (already merged) solves this issue?

@Pigueiras
Copy link
Author

Hi, could you check if this pr: #9564 (already merged) solves this issue?

Sorry I missed your question. If I'm not mistaken #9564 will come with 3.5.2, I will test it when it comes out and let you know 👍

@Pigueiras
Copy link
Author

@MariaAga nope, it's still the same in 3.6.0. I guess we'd need to wait for #9613 😞

@Pigueiras
Copy link
Author

3.6.2 works for us now! 😄

@Pigueiras Pigueiras closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Legacy JS PRs making changes in the legacy Javascript stack Not yet reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants