Fixes #35316 - enhance template-seed error-report #9336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #35316 |
ares
requested changes
Aug 3, 2022
No, it was a development version of #9322 |
m-bucher
force-pushed
the
template_seed_error_handling
branch
from
e0a26fd to
c391e33
Compare
ares
requested changes
Sep 9, 2022
m-bucher
force-pushed
the
template_seed_error_handling
branch
from
c391e33 to
7f8d23a
Compare
m-bucher
force-pushed
the
template_seed_error_handling
branch
from
7f8d23a to
d531711
Compare
|
@ares anything else keeping this from being merged that I can fix? |
m-bucher
force-pushed
the
template_seed_error_handling
branch
from
d531711 to
b1e2b95
Compare
m-bucher
commented
Feb 14, 2023
| @@ -138,6 +139,9 @@ def import_raw_template(contents, vendor = 'Foreman') | |||
| def import_templates(template_paths, vendor = 'Foreman') | |||
| template_paths.each do |path| | |||
| import_raw_template(File.read(path), vendor) | |||
| rescue RuntimeError => e | |||
| Foreman::Logging.exception("Error in seeding the template #{path.inspect} metadata #{e.message}", e) | |||
There was a problem hiding this comment.
Forgot that I really really wanted to have the failing template's path in here 😇
m-bucher
force-pushed
the
template_seed_error_handling
branch
from
b1e2b95 to
e2e8242
Compare
m-bucher
force-pushed
the
template_seed_error_handling
branch
from
e2e8242 to
cb8b360
Compare
m-bucher
force-pushed
the
template_seed_error_handling
branch
from
cb8b360 to
4940ec5
Compare
m-bucher
force-pushed
the
template_seed_error_handling
branch
from
4940ec5 to
600ada8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the problem, that a template could not be seeded, because the Metadata was not valid YAML and therefore could not be parsed
metadatatherefore being empty, the seed reported thatnamewas missing.Having
name:in all templates I was pretty puzzled.This fix will:
metadataas 'Metadata could not be parsed'