Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n - extracting new, pulling from tx #10396

Closed
wants to merge 1 commit into from
Closed

i18n - extracting new, pulling from tx #10396

wants to merge 1 commit into from

Conversation

ColeHiggins2
Copy link
Contributor

No description provided.

@ColeHiggins2 ColeHiggins2 requested a review from ekohl December 3, 2024 16:31
@ColeHiggins2 ColeHiggins2 self-assigned this Dec 3, 2024
@pr-processor pr-processor bot added Not yet reviewed Stable branch PRs that are opened against a stable branch. Usually a cherry pick Waiting on contributor labels Dec 3, 2024
ekohl
ekohl requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a locale update only changes the timestamps then there's no need to merge it. Only if we actually changed translations (any msgid or msgstr entry) then we should merge it.

@ekohl ekohl closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

Assignees

@ColeHiggins2 ColeHiggins2

Labels
Stable branch PRs that are opened against a stable branch. Usually a cherry pick Waiting on contributor
Projects
Foreman Releases
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ColeHiggins2 @ekohl