Fixes #38057 - Use ipv6 too for ssh provisioning #10395
Conversation
| @@ -99,6 +99,6 @@ def validate_ssh_provisioning | |||
|
|
|||
| def provision_host | |||
| # usually cloud compute resources provide IPs but virtualization do not | |||
| provision_interface.ip || provision_interface.fqdn | |||
| provision_interface.ip || provision_interface.ip6 || provision_interface.fqdn | |||
There was a problem hiding this comment.
Like others: should we prefer IPv6 over IPv4? Users will appreciate it if we're consistent and I'd lean to preferring IPv4.
There was a problem hiding this comment.
So in current implementation we do implement IPv4, this way it's less surprising.
I tend to go with less surprises too
There was a problem hiding this comment.
DNS lookups typically also prefer IPv6 (which AFAIK is the non-IP option we already implement). For admins it's more consistent with how the world does it. If needed we can add a release note
There was a problem hiding this comment.
So if I understand you correctly, the current implementation is OK? IPv4, then IPv6 and then FQDN.
There was a problem hiding this comment.
No, IPv6 first and then IPv4 is what I'd prefer. We should start treating IPv4 as legacy just like the rest of the industry
ShimShtein
force-pushed
the
use_ipv6_ssh_orch
branch
from
869c841 to
9594022
Compare
|
Reordered the selection. Now IPv6 i preferred (if it's set) |
We should also use IPv6 if available for ssh orchestration.