Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #38052 - Remove NicIpResolver leftover #10393

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fixes #38052 - Remove NicIpResolver leftover #10393

merged 1 commit into from
Dec 2, 2024

Conversation

ShimShtein
Copy link
Member

It's a leftover. Should be removed.

ekohl
ekohl approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's been unused since f3231f6.

ofedoren
ofedoren approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a feeling this is not used anymore, thanks for confirmations @ShimShtein and @ekohl !

@ofedoren ofedoren merged commit 207137e into theforeman:develop Dec 2, 2024
48 of 51 checks passed
@ekohl
Copy link
Member

ekohl commented Dec 2, 2024

I had a feeling this is not used anymore

I used rg NicIpResolver and git log -S NicIpResolver to determine that. It's not a guarantee, but in my experience it's a very good way to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofedoren ofedoren ofedoren approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShimShtein @ekohl @ofedoren