Fixes #38017 - fog-libvirt 0.13.1 & tests

[stejskalleos]

No description provided.

[stejskalleos]

git bisect

801ce47ed9fe1295f2753eafabdf4e97021767f7 is the first bad commit
commit 801ce47ed9fe1295f2753eafabdf4e97021767f7
Author: Ewoud Kohl van Wijngaarden <[email protected]>
Date:   Thu Jun 13 15:57:28 2024 +0200

    Use test:///default in tests
    
    Rather than mocking, this uses the test connection to use real libvirt
    objects. This brings compatibility with 0.8.3.
    
    It only keeps mocking for dhcp_leases which isn't implemented in the
    test connection. The UUIDs are modified to match.

Some of these changes causing the failures, looking into it.

[ekohl]

Perhaps I broke something with Fog.mock! when changing lib/fog/libvirt/compute.rb. In fog/fog-libvirt@801ce47#diff-aea1b857f83e8b2aa12130a08e1d1f3ce51b5665b0e44024dd2213c9ee555634 I made mock and real the same.

We have this line that could cause an issue:

foreman/test/fixtures/compute_resources.yml

Line 5 in 001cf0d

url: qemu://stam/system

I have no idea if we actually need that. In general I'm not a fan of fixtures in tests.

[stejskalleos]

@ekohl aaand it's 🍏 !

[ekohl]

The test changes look good, just needs to update the bundler file to not point to my fork anymore :)

[evgeni]

technically, this bump is unnecessary, as Foreman itself will work just fine with both 0.12.0 and 0.13.0, it's just the tests that are broken with those versions (0.12.0 because we now rely on the new mocked values from 0.13.0, 0.13.0 because it broke the URL thing).

keeping it at 0.12.0 allows packaging to lazily catch up on this, instead of having to have 0.13.1 go in at the same time as this change to not block nightlies.

(once again: not blocking, but a strong preference ;-) )

[stejskalleos]

Good point, updated.

changes were adressed