Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37932 - Add asterisk to email address users form #10355

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kmalyjur
Copy link
Contributor

It's a draft because I'm unsure about this solution.
Also, when submitting the form with the required email field empty, the "can't be blank" error appears - after unchecking the "mail enabled" checkbox, the error stays.

@adamruzicka
Copy link
Contributor

It's a draft because I'm unsure about this solution.

I'm fine with this. If we ever rewrite the page in react then we might want do it properly, but for now I wouldn't lose any sleep over it.

Also, when submitting the form with the required email field empty, the "can't be blank" error appears - after unchecking the "mail enabled" checkbox, the error stays.

That's pretty standard with erb-based pages, validation errors don't go away until you submit the form again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants