Fixes #37823 - Add Secure Boot and Virtual TPM support for VMware #10324
+90
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2024
|
While testing this PR, I discovered a pre-existing bug on the |
nofaralfasi
force-pushed
the
37823
branch
2 times, most recently
from
ddc7a83 to
f4d3ce0
Compare
- Implement Secure Boot and Virtual TPM functionality for VMware. - Move default firmware setting from `create_vm` to `parse_args`.
stejskalleos
requested changes
Dec 5, 2024
There was a problem hiding this comment.
The combination BIOS+PXELinux BIOS works fine, but UEFI + Grub2 UEFI or Secure Boot always fails with:
2024-12-05T04:43:11 [W|app|41503fe0] Failed to create a compute vmware (VMware) instance molly-haugland.rhos-01.prod.psi.rdu2.redhat.com: RuntimeFault: RuntimeFault.summary
41503fe0 |
2024-12-05T04:43:11 [I|app|41503fe0] Backtrace for 'Failed to create a compute vmware (VMware) instance molly-haugland.rhos-01.prod.psi.rdu2.redhat.com: RuntimeFault: RuntimeFault.summary
41503fe0 | ' error (RbVmomi::Fault): RuntimeFault: RuntimeFault.summary
41503fe0 | /usr/share/gems/gems/rbvmomi2-3.7.1/lib/rbvmomi/vim/Task.rb:15:in `wait_for_completion'
41503fe0 | /usr/share/gems/gems/fog-vsphere-3.7.0/lib/fog/vsphere/requests/compute/create_vm.rb:71:in `create_vm_on_storage_pod'
41503fe0 | /usr/share/gems/gems/fog-vsphere-3.7.0/lib/fog/vsphere/requests/compute/create_vm.rb:39:in `create_vm'
41503fe0 | /usr/share/gems/gems/fog-vsphere-3.7.0/lib/fog/vsphere/models/compute/server.rb:314:in `save'
41503fe0 | /usr/share/foreman/app/models/compute_resources/foreman/model/vmware.rb:518:in `create_vm'
Tested on the latest stream, changes deployed with packit. I'll share instance details in PM.
|
|
||
| test 'returns false and no errors when firmware is EFI and virtual_tpm is disabled' do | ||
| assert_equal false, @cr.send(:validate_tpm_compatibility, '0', 'efi') | ||
| assert_empty @cr.errors.full_messages |
There was a problem hiding this comment.
Suggested change
| assert_empty @cr.errors.full_messages | |
| assert_empty @cr.errors |
Nit: Isn't this enough to check?
stejskalleos
approved these changes
Dec 9, 2024
|
Thanks @nofaralfasi and everyone involved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on: