Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37830 - remove @theforeman/vendor-dev #10323

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

MariaAga
Copy link
Member

We used to import babel and eslint config from it but now we import it from other libraries (and soon will not import it but have it in foreman core).
So @theforeman/vendor-dev is not used in foreman at all.

@MariaAga MariaAga requested a review from a team as a code owner September 17, 2024 16:07
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MariaAga !

@ofedoren
Copy link
Member

Although, we still need an approval from mighty @theforeman/packaging

@adamruzicka adamruzicka merged commit bb08909 into theforeman:develop Dec 12, 2024
66 checks passed
@adamruzicka
Copy link
Contributor

Thank you @MariaAga !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants