Fixes #37768 - Respect the updateParamsByUrl param #10300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
force-pushed
the
37768-dont-update-params-by-url
branch
from
b943fbd to
48e20a1
Compare
|
I do recommend maybe implementing something to remember the search in the packaging wizard but thats a feature |
|
@jeremylenz @MariaAga I see this should be picked to 3.12 (done in #10309), but is this something that should be picked to 3.11 & 3.10 too? |
|
Packages and Errata wizards are only in Katello 4.14 (Foreman 3.12) so it may not be needed before that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates TableIndexPage not to use URL params for the initial search, if you haven't passed the
updateParamsByUrlprop.Without this the host search was bleeding into the searches on the Packages and Errata wizards.