Fixes #37760 - Update pagination component to default to false for URL pagination #10290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updateParamsByUrl is true by default in the component. As a result the effect here:
foreman/webpack/assets/javascripts/react_app/components/Pagination/index.js
Line 47 in aa2a03c
foreman/webpack/assets/javascripts/react_app/common/urlHelpers.js
Line 29 in aa2a03c
I saw some usages of Pagination component and we seem to be passing this. In places where we don't, like Katello Table wrapper , this value will now default to false and pagination will work based on the current value of page.
To test:
Create some test data for CV UI.
Go to Content View page.
Try moving around pages of results using the pagination component on top and bottom of table.