Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37760 - Update pagination component to default to false for URL pagination #10290

Closed
wants to merge 1 commit into from

Conversation

sjha4
Copy link
Contributor

@sjha4 sjha4 commented Aug 27, 2024

The updateParamsByUrl is true by default in the component. As a result the effect here:

sets page to default value of 1.
export const getURIpage = () => Number(getURI().query(true).page) || 1;

I saw some usages of Pagination component and we seem to be passing this. In places where we don't, like Katello Table wrapper , this value will now default to false and pagination will work based on the current value of page.

To test:
Create some test data for CV UI.

100.times do |i|
  cv1 = cv.dup  
  cv1.label='test'+i.to_s  
  cv1.name = 'test'+i.to_s  
  cv1.save!
end 

Go to Content View page.
Try moving around pages of results using the pagination component on top and bottom of table.

@github-actions github-actions bot added the UI label Aug 27, 2024
@sjha4
Copy link
Contributor Author

sjha4 commented Aug 27, 2024

Closing this and making changes in katello to not make it global for everyone.

@sjha4 sjha4 closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant