Fixes #37691 - rename AuthSource Welcome var to fix translation #10255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thorben-D
suggested changes
Jul 30, 2024
| )} | ||
| values={{ | ||
| FreeIPA: <em>FreeIPA</em>, | ||
| Free_IPA: <em>FreeIPA</em>, |
There was a problem hiding this comment.
The formatted message is not broken anymore, but the branding for FreeIPA is missing.
Suggested change
| Free_IPA: <em>FreeIPA</em>, | |
| Free_IPA: <em>{__('FreeIPA')}</em>, |
This way, FreeIPA is still branded to Red Hat Identity Management.
I don't think OpenLDAP or Active Directory need the same treatment, as they do not need to be branded.
Thorben-D
approved these changes
Jul 30, 2024
|
@MariaAga can you re-run the failing tests? I don't seem to have those permissions |
|
Rebased for the failing tests |
ekohl
reviewed
Sep 6, 2024
| )} | ||
| values={{ | ||
| FreeIPA: <em>FreeIPA</em>, | ||
| Free_IPA: <em>{__('FreeIPA')}</em>, |
There was a problem hiding this comment.
For those wondering why this is translated: we (ab)use translations for branding. See https://github.com/RedHatSatellite/foreman_theme_satellite/blob/f78f229ea2f44e34a906ef5c1aaee71586baaf83/lib/foreman_theme_satellite/branded_words.rb#L36
ofedoren
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the theme plugin renames
FreeIPAand adds spaces which breaks the formatter, so I renamed the variable name