Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37615 - Improve help text for the PXE loader in the Host form #10232

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixes #37615 - Improve help text for the PXE loader in the Host form #10232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/views/common/os_selection/_pxe_loader.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
<%
help = _("DHCP filename option to use. Set to None for non-PXE method (e.g. iPXE). Auto-suggested, use OS parameter 'pxe-loader' to override.")
help2 = _("This option specifies the file to be loaded via TFTP during PXE boot. It does not affect the initial boot method (BIOS/UEFI/GRUB/PXE) but configures the file and DHCP options for the network boot.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the last part is true, because AFAIK at least for VMware we configure the VM (by default) based on this option. In #9965 I copied this pattern to libvirt, but that's not merged right now.

%>
<%= fields_for item do |f| -%>
<% loaders = @operatingsystem.available_loaders; if loaders.any? -%>
<%
Expand All @@ -10,7 +14,7 @@
:selected => pxe_loader_selected == true ? f.object.pxe_loader : pxe_loader_selected
},
:label => _('PXE loader'),
:label_help => _("DHCP filename option to use. Set to None for non-PXE method (e.g. iPXE). Auto-suggested, use OS parameter 'pxe-loader' to override."),
:label_help => help + "<br>" + help2,
:label_help_options => { :data => { :placement => 'top' } } %>
<% end -%>
<% end -%>
Loading