Refs #37596 - Add an api request method to table index instead of always assuming 'get' #10223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code is fine, but can you give an example of where its needed? |
ekohl
changed the title
ekohl
reviewed
Jul 1, 2024
| }) => { | ||
| let response = useAPI( | ||
| replacementResponse ? null : 'get', | ||
| replacementResponse ? null : method, | ||
| apiUrl.includes('include_permissions') | ||
| ? apiUrl | ||
| : `${apiUrl}?include_permissions=true`, |
There was a problem hiding this comment.
Unrelated, but this assumes the API URL didn't use any GET parameters before. I'd think that isn't a safe assumption and think it should parse things.
|
Thank you for your contribution! This PR has been inactive for 3 months, closing for now. Feel free to reopen when you return to it. This is an automated process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.