New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37431 - Fix Style/SoleNestedConditional cop #10068

Merged

ehelms merged 1 commit into theforeman:develop from archanaserver:cop-style/solecestedconditional

Oct 16, 2024

Contributor

archanaserver commented Feb 22, 2024

Reviewed and optimized nested conditionals flagged by the Style/SoloNestedConditional cop.

pr-processor bot added Not yet reviewed Waiting on contributor labels

stejskalleos assigned nofaralfasi

nofaralfasi requested changes

View reviewed changes

Contributor

nofaralfasi left a comment •

edited

Loading

The failing tests appear to be related to your changes. Additionally, after applying these changes, there is a need to fix the indentations.

pr-processor bot removed the Not yet reviewed label

nofaralfasi reviewed

View reviewed changes

app/controllers/concerns/foreman/controller/users_mixin.rb Outdated Show resolved Hide resolved

nofaralfasi reviewed

View reviewed changes

app/models/compute_resources/foreman/model/ovirt.rb Outdated Show resolved Hide resolved

nofaralfasi reviewed

View reviewed changes

app/models/concerns/foreman/sti.rb Outdated Show resolved Hide resolved

nofaralfasi reviewed

View reviewed changes

app/models/concerns/orchestration.rb Outdated Show resolved Hide resolved

nofaralfasi reviewed

View reviewed changes

app/registries/menu/item.rb Outdated Show resolved Hide resolved

nofaralfasi reviewed

View reviewed changes

app/services/ui_notifications/rss_notifications_checker.rb Outdated Show resolved Hide resolved

nofaralfasi reviewed

View reviewed changes

lib/net/dhcp/record.rb Outdated Show resolved Hide resolved

archanaserver mentioned this pull request

Fixes #37459 - update rubocop todo file #10081

Closed

14 tasks

archanaserver force-pushed the cop-style/solecestedconditional branch from a0bdc37 to 6aab33d Compare

May 9, 2024 11:07

pr-processor bot added Needs re-review and removed Waiting on contributor labels

archanaserver changed the title ~~Fix Style/SoleNestedConditional cop~~ Fixes #37431 - Fix Style/SoleNestedConditional cop

archanaserver force-pushed the cop-style/solecestedconditional branch from 6aab33d to 968cf2d Compare

May 9, 2024 11:10

ekohl reviewed

View reviewed changes

app/models/concerns/orchestration.rb Outdated Show resolved Hide resolved

app/controllers/api/base_controller.rb Show resolved Hide resolved

archanaserver force-pushed the cop-style/solecestedconditional branch from 968cf2d to 2b79409 Compare

May 15, 2024 07:45

pr-processor bot added the Waiting on contributor label

archanaserver force-pushed the cop-style/solecestedconditional branch from 2b79409 to c9fc726 Compare

May 15, 2024 08:05

pr-processor bot removed the Waiting on contributor label

archanaserver force-pushed the cop-style/solecestedconditional branch from c9fc726 to 8ce6b1d Compare

May 15, 2024 10:19

Contributor Author

archanaserver commented May 15, 2024

@ekohl there is one rubocop offense detected that is Lint/Syntax https://github.com/theforeman/foreman/actions/runs/9093977252/job/24994075137?pr=10068, even though syntax seems correct to me when i checked the file. Do you mind checking the failure here?

archanaserver force-pushed the cop-style/solecestedconditional branch from 8ce6b1d to 808856e Compare

June 24, 2024 20:53

archanaserver force-pushed the cop-style/solecestedconditional branch 2 times, most recently from 45e5ba8 to 5dc1322 Compare

August 1, 2024 08:16

ekohl requested changes

View reviewed changes

app/controllers/concerns/foreman/controller/users_mixin.rb Outdated Show resolved Hide resolved

app/models/concerns/orchestration/dhcp.rb

@@ @@ -173,11 +173,9 @@ def dhcp_update_required? @@
                     (!old.build? && build? && !all_dhcp_records_valid?))
                   # Handle jumpstart
                   # TODO, abstract this way once interfaces are fully used

Member

ekohl Aug 1, 2024

I wonder if this TODO isn't actually solved with 4cbf879. Probably not for this PR, but something to investigate.

Contributor Author

archanaserver Aug 1, 2024

I tried doing something here #10261

pr-processor bot removed the Needs re-review label

pr-processor bot added the Waiting on contributor label

archanaserver force-pushed the cop-style/solecestedconditional branch from 5dc1322 to 24f8887 Compare

August 1, 2024 11:07

pr-processor bot added Needs re-review and removed Waiting on contributor labels

ekohl previously approved these changes

View reviewed changes

pr-processor bot removed the Needs re-review label

Member

ekohl commented Aug 1, 2024

@nofaralfasi have your concerns been addressed?

nofaralfasi previously approved these changes

View reviewed changes

Contributor Author

archanaserver commented Aug 6, 2024

@ekohl, can we get this in?


          Fixes #37431 - Fix Style/SoleNestedConditional cop

4a5739d

archanaserver dismissed stale reviews from nofaralfasi and ekohl via

4a5739d

October 10, 2024 14:31

archanaserver force-pushed the cop-style/solecestedconditional branch from 24f8887 to 4a5739d Compare

October 10, 2024 14:31

archanaserver mentioned this pull request

Fixes #37429 - Update theforeman-rubocop to v0.1.2 #9926

Merged

14 tasks

ehelms approved these changes

View reviewed changes

ehelms merged commit b1cc7eb into theforeman:develop

52 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet