Fixes #37425 - Fix Layout/ArgumentAlignment cop #10051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Feb 20, 2024
archanaserver
force-pushed
the
layout
branch
from
f83e59a to
569140b
Compare
archanaserver
force-pushed
the
layout
branch
from
569140b to
1a548a4
Compare
archanaserver
force-pushed
the
layout
branch
from
1a548a4 to
961d243
Compare
archanaserver
force-pushed
the
layout
branch
from
961d243 to
6fdacb1
Compare
archanaserver
changed the title
14 tasks
ekohl
requested changes
Apr 5, 2024
There was a problem hiding this comment.
theforeman-rubocop has the following style (https://github.com/theforeman/theforeman-rubocop/blob/a4e936fe00d4b839dc027b939f7d364b14faecd2/rules/style.yml#L4-L6):
Layout/ArgumentAlignment:
EnforcedStyle: with_fixed_indentation
IndentationWidth: 2
It would be good to copy this over to .rubocop.yml so no new violations are introduced before we upgrade. Then when we do upgrade, we can drop the config again.
Otherwise 👍 if you create a Redmine issue.
archanaserver
changed the title
archanaserver
force-pushed
the
layout
branch
2 times, most recently
from
3098216 to
55e2d13
Compare
14 tasks
ehelms
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved alignment inconsistencies flagged by the Layout/ArgumentAlignment cop across multiple files.