Fixes #36919 - Add URL validation to HTTP Proxy URL field.

theforeman · Nov 21, 2023 · 7e98f22 · 7e98f22
1 parent 7493355
commit 7e98f22
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/app/controllers/http_proxies_controller.rb b/app/controllers/http_proxies_controller.rb
@@ -25,6 +25,10 @@ def edit
 
   def test_connection
     http_proxy = HttpProxy.new(http_proxy_params)
+    unless http_proxy.valid?
+      raise Foreman::Exception, http_proxy.errors.full_messages.join(', ')
+    end
+
     http_proxy.test_connection(params[:test_url])
 
     render :json => {:status => 'success', :message => _("HTTP Proxy connection successful.")}, :status => :ok