-
Notifications
You must be signed in to change notification settings - Fork 993
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes #37936 - Invalidate jwt for any user or users(API)
- Loading branch information
1 parent
9b8f759
commit 6785cb3
Showing
4 changed files
with
104 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
module Api | ||
module V2 | ||
class RegistrationTokensController < V2::BaseController | ||
include Foreman::Controller::UsersMixin | ||
|
||
include Foreman::Controller::Parameters::User | ||
before_action :authenticate, :only => [:invalidate_tokens] | ||
|
||
def resource_class | ||
User | ||
end | ||
|
||
def find_resource(permission = :view_users) | ||
editing_self? ? User.find(User.current.id) : User.authorized(permission).except_hidden.find(params[:id]) | ||
end | ||
|
||
def action_permission | ||
case params[:action] | ||
when 'invalidate_tokens', 'destroy' | ||
'edit' | ||
else | ||
super | ||
end | ||
end | ||
|
||
api :DELETE, '/users/:id/registration_tokens', N_("Invalidate all JSON Web Tokens (JWTs) for a specific user.") | ||
description <<-DOC | ||
The user you specify will no longer be able to register hosts by using their JWTs. | ||
DOC | ||
param :id, String, :desc => N_("ID of the user"), :required => true | ||
|
||
def destroy | ||
@user = find_resource(:edit_users) | ||
unless @user | ||
raise ::Foreman::Exception.new(N_("No record found for %s"), params[:id]) | ||
end | ||
@user.jwt_secret&.destroy | ||
process_success _('Successfully invalidated JWTs for %s.' % @user.login) | ||
end | ||
|
||
api :DELETE, "/registration_tokens", N_("Invalidate all JSON Web Tokens (JWTs) for multiple users.") | ||
param :search, String, :required => true | ||
description <<-DOC | ||
The users you specify will no longer be able to register hosts by using their JWTs. | ||
DOC | ||
|
||
def invalidate_tokens | ||
raise ::Foreman::Exception.new(N_("Please provide search parameters")) if params[:search].blank? | ||
@users = resource_scope_for_index(:permission => :edit_users).except_hidden.uniq | ||
if @users.blank? | ||
raise ::Foreman::Exception.new(N_("No record found for %s"), params[:search]) | ||
end | ||
JwtSecret.where(user_id: @users).destroy_all | ||
process_success _('Successfully invalidated JWTs for %s.' % @users.pluck(:login).to_sentence) | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
test/controllers/api/v2/registration_tokens_controller_test.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
require 'test_helper' | ||
|
||
class Api::V2::RegistrationTokensControllerTest < ActionController::TestCase | ||
test 'user shall invalidate tokens for self' do | ||
user = User.create :login => "foo", :mail => "[email protected]", :auth_source => auth_sources(:one) | ||
FactoryBot.build(:jwt_secret, token: 'test_jwt_secret', user: user) | ||
delete :destroy, params: { :id => user.id.to_s} | ||
user.reload | ||
assert_response :success | ||
end | ||
test 'user with edit permission should be able to invalidate jwt for another user' do | ||
setup_user 'edit', 'users' | ||
user = users(:scoped) | ||
FactoryBot.build(:jwt_secret, token: 'test_jwt_secret', user: user) | ||
delete :invalidate_tokens, params: { :search => "id ^ (#{user.id})"} | ||
user.reload | ||
assert_response :success | ||
end | ||
|
||
test 'user without edit permission should not be able to invalidate jwt for another user' do | ||
User.current = users(:one) | ||
user = users(:scoped) | ||
FactoryBot.build(:jwt_secret, token: 'test_jwt_secret', user: user) | ||
delete :invalidate_tokens, params: { :search => "id ^ (#{user.id})"} | ||
user.reload | ||
assert_response :forbidden | ||
end | ||
|
||
test 'invalidating jwt should fail without search params' do | ||
setup_user 'edit', 'users' | ||
user = users(:scoped) | ||
FactoryBot.build(:jwt_secret, token: 'test_jwt_secret', user: user) | ||
delete :invalidate_tokens | ||
user.reload | ||
assert_response :error | ||
end | ||
end |