Skip to content

Commit

Permalink
Fixes #37013 - address review comments
Browse files Browse the repository at this point in the history
- Remove layout from context as it's not being used
- Adjust the setting description as it doesn't require page reload anymore
  • Loading branch information
ronlavi2412 committed Jan 16, 2024
1 parent c497cea commit 52e071f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/registries/foreman/settings/general.rb
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
full_name: N_('Show Experimental Labs'))
setting('new_hosts_page',
type: :boolean,
description: N_("Whether or not to show the new overview page for All Hosts (requires reload of page)"),
description: N_("Whether or not to show the new overview page for All Hosts"),
default: false,
full_name: N_('Show New Host Overview Page'))
setting('display_fqdn_for_hosts',
Expand Down
2 changes: 1 addition & 1 deletion webpack/assets/javascripts/react_app/Root/ReactApp.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import ErrorBoundary from '../components/common/ErrorBoundary';
import ConfirmModal from '../components/ConfirmModal';

const ReactApp = ({ layout, metadata, toasts }) => {
const [context, setContext] = useState({ layout, metadata });
const [context, setContext] = useState({ metadata });
const contextData = { context, setContext };
const ForemanContext = getForemanContext(contextData);

Expand Down

0 comments on commit 52e071f

Please sign in to comment.