Fix exception name

[m-bucher]

Not sure if this requires opening an issue 😁

[adamruzicka]

Hrmm, it has been there for ages, has it stopped working?

[m-bucher]

I guess you do not really see the difference, because if this is hit then you get an exception, just not the one that is expected, but a NameError:

home/vagrant/foreman/.vendor/ruby/3.0.0/gems/dynflow-1.9.0/lib/dynflow/dispatcher/client_dispatcher.rb:258:in `with_ping_request_caching'
/home/vagrant/foreman/.vendor/ruby/3.0.0/gems/dynflow-1.9.0/lib/dynflow/dispatcher/client_dispatcher.rb:116:in `publish_request'
[ concurrent-ruby ]
rake aborted!
NameError: uninitialized constant ForemanTasks::TimeoutError
/home/vagrant/foreman/.vendor/ruby/3.0.0/gems/foreman-tasks-10.0.1/lib/foreman_tasks.rb:36:in `block (2 levels) in trigger_task'
/home/vagrant/foreman/.vendor/ruby/3.0.0/gems/algebrick-0.7.5/lib/algebrick/matchers/abstract.rb:74:in `assigns'
/home/vagrant/foreman/.vendor/ruby/3.0.0/gems/algebrick-0.7.5/lib/algebrick/matching.rb:56:in `match_value'
/home/vagrant/foreman/.vendor/ruby/3.0.0/gems/algebrick-0.7.5/lib/algebrick/matching.rb:36:in `block in match?'
/home/vagrant/foreman/.vendor/ruby/3.0.0/gems/algebrick-0.7.5/lib/algebrick/matching.rb:35:in `each'

It might also be that this error is not encountered that often. In my case it was some weird problem in my forklift dev-environment 😅

The only way this would really show is if you explicitly tried to rescue this specific exception 🤔

[adamruzicka]

Oh, I think I see it. Are you on ruby >=3.1? TimeoutError seems to have been removed[1] in timeout-0.2.0 which is shipped with ruby-3.1

[1] - ruby/timeout@14d4212#diff-8ad4c142bc670fe498191f02758e39480e7b06e3ff80be9abfc1d73337d35a83L131

[adamruzicka]

Anyway, TimeoutError used to be an alias for Timeout::Error, let's get thin

[adamruzicka]

Thank you @m-bucher !