Fixes #37285 - Properly process data we get from checking on proxy

[adamruzicka]

No description provided.

[ofedoren]

Do I understand right, that this should correspond with

foreman-tasks/app/lib/actions/proxy_action.rb

Lines 48 to 69 in 124e9c6

	def run(event = nil)
	with_connection_error_handling(event) do |event|
	case event
	when nil
	start_or_resume
	when ::Dynflow::Action::Skip
	# do nothing
	when ::Dynflow::Action::Cancellable::Cancel
	cancel_proxy_task
	when ::Dynflow::Action::Cancellable::Abort
	abort_proxy_task
	when CallbackData
	on_data(event.data, event.meta)
	when ProxyActionMissing
	on_proxy_action_missing
	when ProxyActionStoppedEvent
	on_proxy_action_stopped(event)
	else
	raise "Unexpected event #{event.inspect}"
	end
	end
	end

?

[adamruzicka]

Yes, exactly

[ofedoren]

Where this will be checked instead? Or we don't need this?

[adamruzicka]

I might have taken a shortcut here that I can't really take.

There's the ::Actions::ProxyAction in here, which (as far as I know) is only used in remote execution. Remote execution has a subclass which inherits from ::Actions::ProxyAction and adds a bunch of extensions. The changes here rely on those extensions. Thank you for pointing this out

[adamruzicka]

I kept it mostly intact here and extracted the rex specific parts to theforeman/foreman_remote_execution#900

[adamruzicka]

@ofedoren anything else to do here?

[ofedoren]

Sorry, @adamruzicka, let's get it.