Fixes #36764 - Emit failure events from ObservableAction #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
force-pushed
the
fail-events
branch
from
c5d0b44 to
1df0e6f
Compare
adamruzicka
changed the title
ofedoren
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Hmm.. Did we really support subscription to _failed events, but never fired them? If so, it's funny, because the same, but opposite of that I've made recently as well :/
Thanks, @adamruzicka, checked with webhooks, works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.