Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manual steps from prerequisites - convert2rhel #3542

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Remove manual steps from prerequisites - convert2rhel #3542

merged 1 commit into from
Jan 6, 2025

Conversation

Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Dec 23, 2024 •
edited
Loading

What changes are you introducing?

Removing manual steps from convert2rhel prerequisites

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

The Ansible role takes care of those steps.

Bug SAT-30149 (public)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@github-actions GitHub Actions
Copy link

The PR preview for 0ea41ce is available at theforeman-foreman-documentation-preview-pr-3542.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

maximiliankolb
maximiliankolb approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM and matches the ticket description.

@maximiliankolb maximiliankolb added the style review done No issues from docs style/grammar perspective label Jan 2, 2025
@Lennonka Lennonka added the tech review done No issues from the technical perspective label Jan 6, 2025
@Lennonka Lennonka merged commit 61e13fd into theforeman:master Jan 6, 2025
8 of 9 checks passed
@Lennonka
Copy link
Contributor Author

Lennonka commented Jan 6, 2025

Cherry picked:

@Lennonka Lennonka deleted the remove-manual-steps-convert2rhel branch January 6, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankolb maximiliankolb maximiliankolb approved these changes

@bocekm bocekm bocekm approved these changes

Assignees
No one assigned
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lennonka @bocekm @maximiliankolb