Fix next-server behavior #3540
Merged
Fix next-server behavior #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
The PR preview for 8edf590 is available at theforeman-foreman-documentation-preview-pr-3540.surge.sh The following output files are affected by this PR: |
Lennonka
added
Needs tech review
|
And I now see there's a merge conflict. Please address that so we can merge it. |
Lennonka
added
tech review done
|
I will file another PR for cherry picks, but first it should get style review. :) |
aneta-petrova
approved these changes
Jan 13, 2025
aneta-petrova
added
style review done
9 tasks
Lennonka
force-pushed
the
fix-nextserver-behavior
branch
from
42471e5 to
8edf590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Fixing how the
next-serverDHCP option is determined when it isn't definedWhy are you introducing these changes? (Explanation, links to references, issues, etc.)
#3532 (comment)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: N/A -- see #3561 for CPs