Trim outdated sections from the tuning guide #3534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR preview for bfc5a6a is available at theforeman-foreman-documentation-preview-pr-3534.surge.sh The following output files are affected by this PR: |
|
@Imaanpreet could you have a look? Edit: also, if we say that you always want 16 Puma threads, why don't we make that the default? |
ekohl
commented
Dec 19, 2024
| . Run the installer: | ||
| [options="nowrap" subs="attributes"] | ||
| ---- | ||
| # {foreman-installer} |
There was a problem hiding this comment.
This isn't getting replaced in the rendered document and I can't see why.
apinnick
reviewed
Dec 19, 2024
guides/common/modules/proc_manually-tuning-puma-workers-and-threads-count.adoc
Show resolved
Hide resolved
apinnick
reviewed
Dec 19, 2024
guides/common/modules/con_puma-workers-and-threads-recommendations.adoc
Outdated
Show resolved
Hide resolved
Back with Pulp 2 and Passenger were used this was needed, but these days it's no longer needed.
The installer now automatically sets the pool size large enough to accommodate the additional connections needed by Katello and users shouldn't touch these values anymore.
| @@ -22,9 +22,12 @@ postgresql::server::config_entries: | |||
| autovacuum_vacuum_cost_limit: 2000 | |||
| ---- | |||
| + | |||
| . Run the installer: | |||
| [options="nowrap" subs="attributes"] | |||
There was a problem hiding this comment.
Suggested change
| [options="nowrap" subs="attributes"] | |
| + | |
| [options="nowrap" subs="+quotes,verbatim,attributes"] |
| @@ -24,6 +24,9 @@ apache::mod::event::maxrequestworkers: 1024 | |||
| apache::mod::event::maxrequestsperchild: 4000 | |||
| ---- | |||
| + | |||
| . Run the installer: | |||
| [options="nowrap" subs="attributes"] | |||
There was a problem hiding this comment.
Suggested change
| [options="nowrap" subs="attributes"] | |
| + | |
| [options="nowrap" subs="+quotes,verbatim,attributes"] |
The installer matches threads_min to threads_max and users shouldn't touch this.
Rather than referring readers to a chapter that has some generic instructions, this includes them so the procedure is complete. Fixes: d217c11 ("Add procedure to apply changes to configuration (theforeman#1444)")
This pleases Vale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
The goal is to make the tuning guide as short as possible with only relevant information. Overall we should work towards a good out-of-the-box experience without the need to manually tune. Manual tuning really is for the cases where our automatic code doesn't work.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
For most changes in this PR we have included the changes in the installer or the platform changed. See individual commits for details. Where possible I tied it back to the Redmine issue that changed it.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
For now I've only selected 3.13 as the cherry pick, but looking a the changes I think it also applies to many older versions.
Checklists
Please cherry-pick my commits into: