Fix "content management issues" #3526
Open
+39
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR preview for d59b9cd is available at theforeman-foreman-documentation-preview-pr-3526.surge.sh The following output files are affected by this PR: |
Lennonka
reviewed
Dec 17, 2024
There was a problem hiding this comment.
LGTM, but I've found an additional issue, see #3475 (comment)
maximiliankolb
force-pushed
the
foreman_client
branch
from
fc45366 to
d4d1eb6
Compare
Rebased to "master" and fixed both additional issues. Also converted the upstream URLs to "https". |
Lennonka
approved these changes
Dec 18, 2024
guides/common/modules/ref_best-practices-for-patching-content-hosts.adoc
Outdated
Show resolved
Hide resolved
* Fix URLs * Use attribute for CentOS Stream
maximiliankolb
force-pushed
the
foreman_client
branch
from
d4d1eb6 to
d59b9cd
Compare
Lennonka
added
the
style review done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Fixes for #3475
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: