Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Deployment Scenarios sections into separate modules #3525

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

asteflova
Copy link
Member

What changes are you introducing?

I'm moving all content from topics/Deployment_Scenarios.adoc to smaller modules, without making changes to the actual content.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

To make it easier to include a new modular deployment scenario centered around AWS deployment.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

Copy link

github-actions bot commented Dec 13, 2024

@asteflova
Copy link
Member Author

There are quite a few Vale errors reported but I'd prefer to ignore them because if I fix them, I'll feel the need to start fixing other things, and that's not what this PR is about. I'm only trying to split existing content in topics/ into smaller files to make it easier for @maximiliankolb to work on including the AWS deployment scenario. Are there any objections to this approach?

@maximiliankolb
Copy link
Contributor

@asteflova I tried to make as few comments as possible. the diff proofs that you barely changed anything. I propose to have a look at #3525 (comment)

All other comments are optional. I am also very much OK applying some changes here and there after merging your PR myself in a follow-up PR.

@asteflova
Copy link
Member Author

@asteflova I tried to make as few comments as possible.

Much appreciated!

the diff proofs that you barely changed anything. I propose to have a look at #3525 (comment)

All other comments are optional. I am also very much OK applying some changes here and there after merging your PR myself in a follow-up PR.

I think I addressed everything, except perhaps for one small wording suggestion.

@asteflova
Copy link
Member Author

I'm going to set tech review done because the purpose of this PR is to move existing docs around and avoid changing the text. I have no doubt that the deployment scenario could use a thorough review because they seem to have been around for quite a while but this is not the right time for that.

@asteflova asteflova added the tech review done No issues from the technical perspective label Jan 3, 2025
@maximiliankolb maximiliankolb added the style review done No issues from docs style/grammar perspective label Jan 7, 2025
@asteflova asteflova merged commit c87daa0 into theforeman:master Jan 7, 2025
8 of 9 checks passed
@asteflova asteflova deleted the deployment-scenarios-modules branch January 7, 2025 17:14
@asteflova
Copy link
Member Author

Merged to "master", no cherry-picks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants