-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Deployment Scenarios sections into separate modules #3525
Move Deployment Scenarios sections into separate modules #3525
Conversation
The PR preview for 7405df3 is available at theforeman-foreman-documentation-preview-pr-3525.surge.sh The following output files are affected by this PR: |
There are quite a few Vale errors reported but I'd prefer to ignore them because if I fix them, I'll feel the need to start fixing other things, and that's not what this PR is about. I'm only trying to split existing content in |
guides/doc-Planning_for_Project/topics/Deployment_Scenarios.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_single-location-with-segregated-subnets.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_single-location-with-segregated-subnets.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_projectserver-with-multiple-manifests.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_projectserver-with-multiple-manifests.adoc
Outdated
Show resolved
Hide resolved
@asteflova I tried to make as few comments as possible. the diff proofs that you barely changed anything. I propose to have a look at #3525 (comment) All other comments are optional. I am also very much OK applying some changes here and there after merging your PR myself in a follow-up PR. |
Much appreciated!
I think I addressed everything, except perhaps for one small wording suggestion. |
I'm going to set |
Merged to "master", no cherry-picks. |
What changes are you introducing?
I'm moving all content from
topics/Deployment_Scenarios.adoc
to smaller modules, without making changes to the actual content.Why are you introducing these changes? (Explanation, links to references, issues, etc.)
To make it easier to include a new modular deployment scenario centered around AWS deployment.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: