-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update procedure to configure TLS for LDAP #3499
Conversation
It's also not needed to restart the service.
The PR preview for bf3daf6 is available at theforeman-foreman-documentation-preview-pr-3499.surge.sh The following output files are affected by this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking over. Again a great simplification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style-wise it LGTM; though I am not sure if that would work on Foreman on Debian/Ubuntu. But it's an improvement, so let's get it in.
Good call. It would not, but the previous instructions also didn't work. The Debian equivalent is to place the file in |
Thanks Ewoud for providing the cmd/path. I will fix this in a follow-up PR so that it does not further block this PR. See #3500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, this now matches https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/securing_networks/using-shared-system-certificates_securing-networks#adding-new-certificates_using-shared-system-certificates. Perhaps we should refer to it?
I saw that section and didn't think it would add much value. But why not, let's add a link. |
I don't think we can replace the steps on our side with a link (update-ca-trust extract is not part of the RHEL docs) but in https://issues.redhat.com/browse/SAT-19820, Evgeni does recommend adding a link so that's what I did. Except that I'd rather not link to a specific section, only to the whole chapter/assembly (chapter links shouldn't change as much as section links). |
Perhaps that's a RHEL docs bug. Technically it works if you don't pass one, but there's a difference. Quoting
That makes me think users should pass the |
Hi, we plan to revamp the Managing trusted system certificates chapter in the RHEL Security hardening (tracked in [1]). And we'll also reflect what is currently deprecated [2, 3]. Perhaps I could make a quick fix just to incorporate the missing argument. |
Great, thanks a lot, Mirek! Looking at the RHEL RNs that you linked:
which I believe confirms @ekohl's suspicion. If you do manage to apply the quick fix to update-ca-trust @mjahoda, I would appreciate it if you let me know because then I'd look into replacing the procedure steps on our side with a link to your guide. However, for now, I think this PR is good enough to be merged. If anyone disagrees, please let me know. |
This is how we (or at least, I) found out the hard way: voxpupuli/puppet-trusted_ca@b3416c5 & theforeman/puppet-foreman_proxy_content@53187d9 were the result of a very frustrating Friday when the change landed in CentOS Stream. |
I'll raise a follow-up PR to get the changes to 3.10 and below. |
JFYI, the quick fix (the addition of "extract") is available in the published RHEL 8 and 9 docs: https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/securing_networks/using-shared-system-certificates_securing-networks#adding-new-certificates_using-shared-system-certificates |
What changes are you introducing?
I'm updating the procedure to configure TLS for LDAP authentication:
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
I noticed https://issues.redhat.com/browse/SAT-19821 and #2409 and thought "why not?"
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
A separate PR will probably be needed for some of the older branches due to conflicts but #2409 suggests that we should get the fixes there too.
Please cherry-pick my commits into: