Modularize deployment scenarios #3498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR preview for 549fc81 is available at theforeman-foreman-documentation-preview-pr-3498.surge.sh The following output files are affected by this PR: |
asteflova
force-pushed
the
mod_deploy_scenarios
branch
from
5a0f6b3 to
549fc81
Compare
|
@maximiliankolb Would this make your plans with AWS easier? If not, I can just close this again. |
|
I talked to @maximiliankolb, the conclusion is to drop this PR and focus on #3485 and #3456 separately. There is currently no need for a middle-ground temporary solution presented in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
This PR takes the contents of
doc-Planning_Project/topics/Deployment_Scenarios.adocfrom #3456 and introduces it separately from that PR and in modular form.I'm not making any changes to the content itself, I just created separate module files and tweaked a broken xref here and there.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Because there is now a plan to include AWS deployment content as a deployment scenario in the Planning guide, I thought it might help to work with modularized deployment scenarios. And considering that multiple writers approved of the structure that #3456 introduces, I think it's reasonably safe to work on AWS in the context of the modularized deployment scenarios already.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: