Add Secure Boot for Satellite and RHEL #3488
Conversation
|
The PR preview for a7b41a3 is available at theforeman-foreman-documentation-preview-pr-3488.surge.sh The following output files are affected by this PR: |
Lennonka
force-pushed
the
add-secureboot-rhel
branch
from
86fb5e0 to
a7b41a3
Compare
|
Rebased. |
Lennonka
added
Needs tech review
There was a problem hiding this comment.
diff and rendered docs LGTM.
The only minor improvement that I see is "My_Operating_System_in_Lowercase". Maybe you want to introduce an attribute for that? Your call.
I am currently unsure why we didn't do that in the first place. If you're interested, I could ping people that implemented this in the beginning of January.
maximiliankolb
added
style review done
| @@ -21,6 +20,7 @@ ifndef::satellite[] | |||
| :parent-client-pkg-ext: {client-pkg-ext} | |||
| :secureboot-os-name: My_Operating_System_In_Lowercase | |||
There was a problem hiding this comment.
@maximiliankolb There actually is an attribute for that but it isn't being modified anywhere 😆
Perhaps it's a good idea to request a PR to do that for the other OSs.
I'm not sure what the value is supposed to be, e.g. is rhel good enough? Does the directory name even matter as long as it's consistent in the whole procedure?
There was a problem hiding this comment.
Yeah, let's keep it consistent for now, and then think/ask if we can overwrite this attribute for each OS in a follow-up PR.
What changes are you introducing?
Adding Secure Boot support for Satellite and RHEL.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
SAT-23035 Epic
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: N/A - for 3.14