Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document VCS integration in foreman_ansible plugin #2920

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Thorben-D
Copy link

@Thorben-D Thorben-D commented Mar 28, 2024

This pull request adds documentation for VCS integration in foreman_ansible.
Still subject to change.

Requires: theforeman/foreman_ansible#676
Requires: theforeman/smart_proxy_ansible#85

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance to handle this using foreman-instaler?

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Apr 2, 2024
@Thorben-D Thorben-D force-pushed the issue/OR-4617_clone_ansible_roles_from_vcs_doc branch from fd51ddb to 44ccc02 Compare April 8, 2024 07:36
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Apr 8, 2024
Note that you can only clone Ansible roles through `http` and `https`.

* Click *Examine* to select a git revision from the list of branches and tags.
* Toggle between *Skipping existing* and *Update existing* to allow {Project} to override a given role if it is already present on the {SmartProxy}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Toggle between *Skipping existing* and *Update existing* to allow {Project} to override a given role if it is already present on the {SmartProxy}.
* Toggle between *Skipping existing* and *Update existing* to allow {Project} to override a given role if it is already present on your {SmartProxy}.

@@ -18,6 +18,7 @@ endif::[]
* `/usr/share/ansible/roles`
* `/etc/ansible/collections`
* `/usr/share/ansible/collections`
* `(optional) VCS_INTEGRATION_PATH/ansible/roles`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does "VCS_INTEGRATION_PATH" come from? Is this something a user has to replace?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For nightly, I think these manualy steps are more or less OK. For the next release, I think it would be best to do this via foreman-installer.

@MariaAga
Copy link
Member

MariaAga commented Apr 22, 2024

Thanks for documenting this feature! I followed the guide and dont have the vcs capability in the Ansible feature. is there something else need doing (other than the steps in the doc)?
Also ran service foreman-proxy restart and it didnt help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants