Skip to content

Commit

Permalink
CI: Build with warnings=extra to catch 'em all
Browse files Browse the repository at this point in the history
... on all platforms but MSVC, as it still has a number of unsolved warnings
in its `/Wall` level. Some of it might be valid, others might be overkill,
this needs further assessment and fixes. (We could also change the `extra`
level to `/W4` on MSVC if that's more meaningful.)
  • Loading branch information
akien-mga committed Nov 9, 2020
1 parent 8a318fe commit 5af5c86
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/android_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [push, pull_request]
# Global Settings
env:
GODOT_BASE_BRANCH: master
SCONSFLAGS: platform=android verbose=yes warnings=all werror=yes --jobs=2
SCONSFLAGS: platform=android verbose=yes warnings=extra werror=yes --jobs=2
SCONS_CACHE_LIMIT: 4096

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ios_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [push, pull_request]
# Global Settings
env:
GODOT_BASE_BRANCH: master
SCONSFLAGS: platform=iphone verbose=yes warnings=all werror=yes --jobs=2
SCONSFLAGS: platform=iphone verbose=yes warnings=extra werror=yes --jobs=2
SCONS_CACHE_LIMIT: 4096

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/javascript_builds.disabled
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [push, pull_request]
# Global Settings
env:
GODOT_BASE_BRANCH: master
SCONSFLAGS: platform=javascript verbose=yes warnings=all werror=yes --jobs=2
SCONSFLAGS: platform=javascript verbose=yes warnings=extra werror=yes --jobs=2
SCONS_CACHE_LIMIT: 4096
EM_VERSION: 1.39.20
EM_CACHE_FOLDER: 'emsdk-cache'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/linux_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [push, pull_request]
# Global Settings
env:
GODOT_BASE_BRANCH: master
SCONSFLAGS: platform=linuxbsd verbose=yes warnings=all werror=yes --jobs=2
SCONSFLAGS: platform=linuxbsd verbose=yes warnings=extra werror=yes --jobs=2
SCONS_CACHE_LIMIT: 4096

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/macos_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: [push, pull_request]
# Global Settings
env:
GODOT_BASE_BRANCH: master
SCONSFLAGS: platform=osx verbose=yes warnings=all werror=yes --jobs=2
SCONSFLAGS: platform=osx verbose=yes warnings=extra werror=yes --jobs=2
SCONS_CACHE_LIMIT: 4096

jobs:
Expand Down

0 comments on commit 5af5c86

Please sign in to comment.