Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating auth firebase google services #530

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

simtop
Copy link
Contributor

@simtop simtop commented Jun 22, 2024

Updating google play services auth and firebase bom and google services plugin.

@simtop simtop requested a review from jbors June 22, 2024 00:00
@simtop
Copy link
Contributor Author

simtop commented Jun 22, 2024

Hello @jbors this worked from my side and all UI Tests passed locally, let's see if it works in bitrise.

@simtop
Copy link
Contributor Author

simtop commented Jun 22, 2024

No, it's not fixed, the error comes between the virtual machine of bitrise and R8 version and Kotlin compatibility, do you know if we made any changes related to that? @jbors

"WARNING: D8: An error occurred when parsing kotlin metadata. This normally happens when using a newer version of kotlin than the kotlin version released when this version of R8 was created. To find compatible kotlin versions, please see: https://developer.android.com/studio/build/kotlin-d8-r8-versions
"

@jbors
Copy link
Contributor

jbors commented Jun 22, 2024

I mean, yeah we bumped kotlin versions and I have been messing with proguard rules. Doesn't explain why it's only when we bump this package that it goes wrong. Maybe it matters which version of kotlin the package has been compiled on?

@simtop
Copy link
Contributor Author

simtop commented Jun 22, 2024

Yes probably, I tried lowering kotlin version, the problem is between bitrise virtual machine app and kotlin version, maybe they are behind and there is some incompatibility.

I think the VM job passed, if everything passes let's merge it, and update to kotlin 2.0 when it's stable.

@jbors
Copy link
Contributor

jbors commented Jun 22, 2024

I mean, alternatively we just do not update this for now and wait for kotlin version to catch up?

@simtop
Copy link
Contributor Author

simtop commented Jun 22, 2024 via email

@simtop
Copy link
Contributor Author

simtop commented Jun 22, 2024

@jbors Let's keep this branch/PR open to experiment when we can update few more things, it looks like it still fails. It's best to retry again when we update to kotlin 2.0

@jbors
Copy link
Contributor

jbors commented Jun 22, 2024

@simtop Cool. Thanks for helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants