Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to print any information about gQUIC packets. #960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't try to print any information about gQUIC packets. #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion print-quic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,10 @@ quic_print_packet(netdissect_options *ndo, const u_char *bp, const u_char *end)
version = GET_BE_U_4(bp);
bp += 4;

if (version == 0)
if (version >> 24 == 0x51) {
ND_PRINT(", unsupported gquic");
return end;
} else if (version == 0)
ND_PRINT(", version negotiation");
else if (packet_type == QUIC_LH_TYPE_INITIAL)
ND_PRINT(", initial");
Expand Down
2 changes: 1 addition & 1 deletion tests/gquic.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
1 06:42:38.000000 IP (tos 0x0, ttl 64, id 38137, offset 0, flags [DF], proto UDP (17), length 1378)
10.7.0.3.38824 > 216.58.195.67.443: quic, initial, v51303436, length 0, protected
10.7.0.3.38824 > 216.58.195.67.443: quic, unsupported gquic