Modify goals-list and connections-list to automatically adapt to text size #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanavdb
requested changes
Oct 31, 2024
|
Ah I'll likely have to add the same autoscaling to the description section, did not run into that issue in my personal testing. Will fix that later today |
|
Corrected |
stanavdb
approved these changes
Nov 1, 2024
|
Just for the sake of tracking who closed what issues, can you leave a comment on #112? Can't assign you, unless you leave a comment |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
What type of pull request is this? (e.g., Bug fix, Feature, Refactor, etc.)
Description
Currently, the goals and connections list are not configured to scale, and automatically force a height of 2rem for all elements. This leads to overflow issues when larger goals or connections are written.
I have modified the height to be automatic and added a small amount of padding on the top and bottom so the text looks naturally seated within the range. The overall height for a one-line goal is the same(.25 top padding, 1.5 min-size, .25 bottom padding)
Related Issue
Closes #112
How Has This Been Tested?
Tested goals and connections of various sizes, and verify that all previous elements fit and still work as intended.
Screenshots (if applicable)
Before:
After:
Checklist:
Additional context
Add any other context or information here that would be useful for reviewers.