Allow Damaging Items to Override Graze Damage #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for override formula
zithith
commented
Oct 23, 2024
stanavdb
reviewed
Oct 24, 2024
|
Can you drop a comment in #102 so that I can assign it to you? |
…ibutable sources. Improved base graze damage calculation
…into feat/graze-damage-override-#102
MangoFVTT
reviewed
Nov 3, 2024
stanavdb
reviewed
Nov 3, 2024
Removed extra addition of modifier by apply damage function. Removed excess style declaration.
…ing dice only option
…gn our implementation following notes from Brotherwise
…ns, fixed typos and linting, updated code comments
stanavdb
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
What type of pull request is this? (e.g., Bug fix, Feature, Refactor, etc.)
Description
Allow damaging effects to specify a new formula for calculating graze damage value. This is mostly to satisfy the requirement for NPCs/Adversaries who can have values in official statblocks for grazing hits that don't follow the standard rules for attacks.
Related Issue
Closes #102
How Has This Been Tested?
Describe how you tested the changes and how others can replicate the testing steps.
In Progress
Screenshots (if applicable)
Add screenshots or GIFs that help illustrate the changes, especially if they affect the UI or user-facing aspects of the system.
Checklist:
Additional context
I will presume that this change won't add any sorts of flags or complexity such as a checkbox to add ability mod to the damage or the like. If GMs want an odd action that uses a mod in the grazing formula, then they can just use the
@property shorthand?