Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Nested DictField in model_tags #1553

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Replace Nested DictField in model_tags #1553

merged 1 commit into from
Jan 9, 2025

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Jan 8, 2025 •
edited
Loading

Addresses

Changes

  • Remove child dict field from assisted tagging serializer

Mention related users here if any.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sudan45 sudan45 changed the title Refactor model_tags by replacing nested DictField with a single DictF… Replace Nested DictField in model_tags Jan 8, 2025
@AdityaKhatri AdityaKhatri merged commit e3c2eae into develop Jan 9, 2025
9 checks passed
@AdityaKhatri AdityaKhatri deleted the fix/remove-nested-dictfield branch January 9, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susilnem susilnem susilnem approved these changes

@AdityaKhatri AdityaKhatri AdityaKhatri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudan45 @AdityaKhatri @susilnem