Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clone analysis mutation #1547

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Dec 12, 2024

Addresses

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sudan45 sudan45 marked this pull request as draft December 12, 2024 09:32
@sudan45 sudan45 force-pushed the feature/clone-analysis-mutation branch from 1d31918 to 687f41f Compare December 17, 2024 05:49
@sudan45 sudan45 marked this pull request as ready for review December 17, 2024 05:49
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 65.51724% with 10 lines in your changes missing coverage. Please review.

Project coverage is 79.42%. Comparing base (6b89470) to head (687f41f).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
apps/analysis/serializers.py 52.38% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1547   +/-   ##
========================================
  Coverage    79.42%   79.42%           
========================================
  Files          464      464           
  Lines        30402    30424   +22     
  Branches      3420     3421    +1     
========================================
+ Hits         24146    24164   +18     
- Misses        6256     6260    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

apps/analysis/serializers.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudan45 Some minor changes.

@sudan45 sudan45 force-pushed the feature/clone-analysis-mutation branch from 21a393c to 879c0dd Compare December 18, 2024 08:24
@sudan45 sudan45 force-pushed the feature/clone-analysis-mutation branch from 879c0dd to b1ade10 Compare December 18, 2024 12:03
@subinasr subinasr merged commit ffe2b2f into develop Dec 19, 2024
8 of 9 checks passed
@subinasr subinasr deleted the feature/clone-analysis-mutation branch December 19, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants