Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement leave project functionality #1541

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Implement leave project functionality #1541

merged 1 commit into from
Dec 5, 2024

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Dec 3, 2024 •
edited
Loading

Address:

Features

  • Added feature to allow users to leave a project.
  • Included validations to prevent project owners from leaving.
  • Updated project membership

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sudan45 sudan45 marked this pull request as draft December 3, 2024 04:49
@sudan45 sudan45 changed the title Add serializer and mutation Leave Project Dec 3, 2024
@sudan45 sudan45 force-pushed the feature/leave-project branch from b4dc42b to 411f5dc Compare December 3, 2024 09:34
@shreeyash07 shreeyash07 mentioned this pull request Dec 4, 2024
Merged
11 tasks
@sudan45 sudan45 force-pushed the feature/leave-project branch from 672982e to e5588e8 Compare December 5, 2024 05:11
@sudan45 sudan45 marked this pull request as ready for review December 5, 2024 05:15
@sudan45 sudan45 changed the title Leave Project Implement leave project functionality Dec 5, 2024
@sudan45 sudan45 force-pushed the feature/leave-project branch 2 times, most recently from 3378b29 to 0337bd1 Compare December 5, 2024 05:25
@AdityaKhatri AdityaKhatri self-assigned this Dec 5, 2024
Rup-Narayan-Rajbanshi
Rup-Narayan-Rajbanshi requested changes Dec 5, 2024
View reviewed changes
apps/project/serializers.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the feature/leave-project branch from 0337bd1 to c3f9958 Compare December 5, 2024 06:53
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi mentioned this pull request Dec 5, 2024
Merged
9 tasks
@AdityaKhatri AdityaKhatri force-pushed the feature/leave-project branch from c3f9958 to c1f8ea9 Compare December 5, 2024 11:00
@sudan45 sudan45 force-pushed the feature/leave-project branch 2 times, most recently from c3f9958 to 64c005e Compare December 5, 2024 11:22
@AdityaKhatri AdityaKhatri force-pushed the feature/leave-project branch from 64c005e to 0de975e Compare December 5, 2024 11:33
@AdityaKhatri AdityaKhatri force-pushed the feature/leave-project branch from 0de975e to 2fa7ef9 Compare December 5, 2024 11:35
@AdityaKhatri AdityaKhatri merged commit 2fdf67c into develop Dec 5, 2024
8 of 9 checks passed
@AdityaKhatri AdityaKhatri deleted the feature/leave-project branch December 5, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susilnem susilnem susilnem approved these changes

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi approved these changes

@AdityaKhatri AdityaKhatri AdityaKhatri approved these changes

@thenav56 thenav56 Awaiting requested review from thenav56

Assignees

@AdityaKhatri AdityaKhatri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sudan45 @AdityaKhatri @Rup-Narayan-Rajbanshi @susilnem